Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't normalize URL too early as this could be a tcp or udp runner #657

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Nov 14, 2022

don't normalize URL too early as this could be a tcp or udp runner (for web ui/rapi calls)

avoids/fixes:

14:56:42 I uihandler.go:113> Starting http load request from [::1]:49334 for udp://localhost:1111
14:56:42 W http_client.go:152> Assuming http:// on missing scheme for 'udp://localhost:1111'

Fixes #651

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 88.5% // Head: 88.5% // No change to project coverage 👍

Coverage data is based on head (dd283b1) compared to base (fac8faf).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #657   +/-   ##
======================================
  Coverage    88.5%   88.5%           
======================================
  Files          30      30           
  Lines        4361    4361           
======================================
  Hits         3858    3858           
  Misses        337     337           
  Partials      166     166           
Impacted Files Coverage Δ
rapi/restHandler.go 87.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly merged commit c2f2f76 into master Nov 15, 2022
@ldemailly ldemailly deleted the fix_651 branch November 15, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning about assuming http:// when doing tcp:// or udp:// load test
2 participants