feat: Added command fcli ssc aviator audit to v3.x-develop

[kireetivar]

New aviator audit Command in fcli-ssc Module

This PR adds the fcli ssc aviator audit command to the fcli-ssc module:

Command:
fcli.jar ssc aviator audit --av <appVersionNameOrId> -f <optional_file_path> --at <aviator_token> --tn <tenant_name> --au <aviator_grpc_server_url>

Key Features:

1. Purpose: Downloads an FPR from SSC using --av, processes it via the new fcli-aviator module, and updates the FPR using responses from the Aviator GRPC server before re-uploading to SSC.
2. New Module: fcli-aviator handles FPR processing and GRPC communication.
3. SSC Integration: Utilizes existing SSC authentication(session).

Workflow:

1. Download FPR via appVersionNameOrId.
2. Process and update FPR using GRPC server responses.
3. Upload the updated FPR back to SSC.

Additional Changes:

1. Added proper file handling after file download.
2. Removed task zipResources_actions as it was unnecessary.
3. Removed some dependencies.
   • After these commits:
     • The .jar size increased from 22 MB to 42 MB.
     • The .exe size increased from 93 MB to 111 MB.
   • The majority of this size increase comes from the gRPC and proto libraries, which are necessary.
4. Changed variable names in SSCAviatorAuditCommand.java to maintain consistency with other commands.
5. Removed the IActionCommandResultSupplier key from the returned JsonNode object as it was redundant in SSCAviatorAuditCommand.java.
6. Added @DefaultVariablePropertyName("id") to SSCAviatorAuditCommand.java so the artifact ID value can be stored and used in subsequent commands.

[rsenden]

Fcli already provides logging configuration, so what's this used for exactly? Logging to console may cause issues when used in combination with fcli progress writers.

If this is used to output progress messages to the user, it might be better to use the fcli progress writer instead, for consistency with the remainder of fcli. I can understand that want to keep the aviator module independent of fcli classes, so potentially we could investigate the option of wrapping the progress writer in a logging appender, such that all info/warn messages are indirectly written using the progress writer. Alternatively, we could add an abstraction layer, with the aviator module providing a 'logger' interface, for which an implementation is passed from the fcli command to the AuditFPR class. This fcli-specific implementation could then delegate to the progress writer.

Alternatively, the fcli ssc aviator audit command should either not use any progress writer, or the progress writer should be closed before calling AuditFPR.auditFpr(fprFile, token, tenantName, url);, and, if needed, re-opened after that call.

[kireetivar]

Thanks for the feedback! We've removed AviatorLoggingConfigure.java to eliminate console conflicts with fcli's ProgressWriter. To address the progress message output, I introduced the IAviatorLogger abstraction in fcli-aviator and implemented it as AviatorLoggerImpl, which uses SLF4J for both console and file logging. Please let me know if any further changes are required.

[rsenden]

In fcli, we usually don't explicitly log an error when throwing an exception, as the error message is already included in the exception that will be logged (if logging is enabled) and shown to the user.

[kireetivar]

Fixed this 👍

[rsenden]

Do we want to include artifactId? Maybe we don't need some of the other properties like active, issueTemplateName, createdBy, as these are not relevant for the audit operation. Also, plain id might be confusing as to whether this refers to the appversion id or the artifact id, so maybe we should have a column header that makes it more clear that this is the application version id (or just remove id here?)

[kireetivar]

removed 'id' and other options and added 'artifactId'.

[kireetivar]

I’ve added the id back in, moved artifactId to the end, and removed the active field.

[kireetivar]

Sorry ! my bad, I didn’t check your email before replying here 😅 I’m currently looking into solutions for the logging issue and will update the PR once it’s resolved.