-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial changes for async support #182
Conversation
This is fixed in MbedTLS 2.28, I think? |
f72fb41
to
8550098
Compare
c5fc912
to
4086897
Compare
mbedtls/src/pk/mod.rs
Outdated
assert_eq!(pk.verify(digest, &[], &signature[0..len]).unwrap_err(), Error::PkBadInputData); | ||
|
||
|
||
let mut dummy_sig = vec![]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: doesn't need to be Vec.
mbedtls/src/ssl/context.rs
Outdated
@@ -89,7 +84,23 @@ define!( | |||
impl<'a> UnsafeFrom<ptr> {} | |||
); | |||
|
|||
impl Context { | |||
define!( | |||
#[c_custom_ty(ssl_context)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed not using a macro here
4086897
to
ec54df6
Compare
ec54df6
to
0044496
Compare
bors r+ |
Build succeeded:
|
Splitting #163 into separate parts.
Also rebased since @raoulstrackx already helped with some pieces of the PR above.
Code does the following: