This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 126
Adding GCS as a policy-library store for on-GKE #356
Merged
kevensen
merged 8 commits into
forseti-security:master
from
kevensen:policy-library-improvements
Oct 30, 2019
Merged
Adding GCS as a policy-library store for on-GKE #356
kevensen
merged 8 commits into
forseti-security:master
from
kevensen:policy-library-improvements
Oct 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #341 |
Need to test
|
1 task
gkowalski-google
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please create a ticket to support branch configuration on GCE.
@@ -69,7 +69,9 @@ In order to operate with the Service Account you must activate the following API | |||
| k8s\_tiller\_sa\_name | The Kubernetes Service Account used by Tiller | string | `"tiller"` | no | | |||
| network | The VPC where the Forseti client and server will be created | string | `"default"` | no | | |||
| org\_id | GCP Organization ID that Forseti will have purview over | string | n/a | yes | | |||
| policy\_library\_repository\_url | The git repository containing the policy-library. | string | `"https://github.com/forseti-security/policy-library"` | no | | |||
| policy\_library\_repository\_branch | The specific git branch containing the policies. | string | `"master"` | no | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the GCE behavior is hard-coded to master branch. It's fine to support different branches, but if we do it for GKE, then we should do the same for GCE. That would mean a change here: https://github.com/forseti-security/forseti-security/blob/master/install/gcp/scripts/initialize_forseti_services.sh#L55
Opened #366 |
hshin-g
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: