Always specify cargo toolchain #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fornwall
force-pushed
the
ignore-rust-toolchain-files
branch
from
f1abe12 to
37c88dc
Compare
By always specifying a cargo toolchain (the +${TOOLCHAIN} option) we
avoid being affected by rust-toolchain(.toml) files. Fixes #31.
fornwall
force-pushed
the
ignore-rust-toolchain-files
branch
from
37c88dc to
51f4ab6
Compare
|
As this breaks when cargo is not a rustup proxy, let's close this in favour of #73, which avoids rust toolchain files by building with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By always specifying a cargo toolchain (the
+${TOOLCHAIN}option) we avoid being affected by rust-toolchain(.toml) files.Fixes #31 (however, see that linked issue for comments about this change, and how it will break if cargo is not a rustup proxy command or a
stabletoolchain is not installed).