Update WidgetBool process method to restrict value changes to edit mode #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check for edit mode before processing UP/DOWN commands. This ensures that value toggling only happens when the menu is in edit mode, improving user experience and preventing unintended changes.
WalkthroughThe changes in the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/widget/WidgetBool.h(1 hunks)
🔇 Additional comments (1)
src/widget/WidgetBool.h (1)
48-48: 🧹 Nitpick (assertive)Update log message to use correct class name.
The log message uses "WidgetToggle" but the class is named "WidgetBool". This could cause confusion during debugging.
- LOG(F("WidgetToggle::toggle"), value); + LOG(F("WidgetBool::toggle"), value);⛔ Skipped due to learnings
Learnt from: forntoh PR: forntoh/LcdMenu#248 File: src/widget/WidgetBool.h:46-46 Timestamp: 2024-11-12T11:59:37.512Z Learning: In the `Widget<bool>` class (`src/widget/WidgetBool.h`), it is acceptable to use `"WidgetToggle::toggle"` in log messages since it represents the toggle functionality (always switches between `true` and `false`).
|
Memory usage change @ ca2ebc8
Click for full report table
Click for full report CSV |
forntoh
changed the title
|
Memory usage change @ 80f8840
Click for full report table
Click for full report CSV |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for edit mode before processing UP/DOWN commands. This ensures that value toggling only happens when the menu is in edit mode, improving user experience and preventing unintended changes.
Fixes #294
Checklist
General Requirements
breaking-changeif it introduces a breaking change.Bug Fix
bugfix.Summary by CodeRabbit