Manifest generation refactoring #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepango
changed the title
michaem
reviewed
Feb 21, 2021
| } | ||
| } | ||
|
|
||
| val properties = Properties() |
There was a problem hiding this comment.
May be better to move this code block into androidProjectConfiguration? (underhood)
Or, It should lay on top-level gradle build script?
There was a problem hiding this comment.
Yeah it needs a bit more refinement, next PR will do
michaem
approved these changes
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating manifest during the configuration phase, I've used the
beforeEvaluatecallback, so it's now moved to the initialization phase which potentially should play much better with default Gradle behaviorTurn out it was a bad idea, before evaluating callback was set during the configuration stage and seems like never triggered. Probably It would make sense to try to set it through
subProjectscallback.