Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate progress bar from databinding module to viewBinding #123

Merged
merged 1 commit into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion application/binary/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ androidBinary(
target(":feature:characters:favorite:impl"),

target(":common:extensions:android-util"),
target(":common:progressbar:databinding"),
// target(":common:util-native"),
target(":core:mvvm:library"),
target(":core:di:library")
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
dataBinding(
packageName = "com.stepango.blockme.common.progressbar.databinding",
viewBinding(
packageName = "com.stepango.blockme.common.progressbar.viewbinding",

dependencies = deps(
androidx.appcompat,
androidx.constraintlayout
) + deps(
target(":common:extensions:android-util"),
target(":common:extensions:databinding-adapter"),
target(":common:progressbar:res")
)
)
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@
* limitations under the License.
*/

package com.stepango.blockme.common.progressbar.databinding
package com.stepango.blockme.common.progressbar.viewbinding

import android.content.Context
import android.view.LayoutInflater
import android.view.View
import androidx.annotation.StringRes
import androidx.appcompat.app.AlertDialog
import com.stepango.blockme.common.extensions.android.util.getString
import com.stepango.blockme.common.progressbar.databinding.databinding.ViewProgressDialogBinding
import com.stepango.blockme.common.progressbar.viewbinding.databinding.ViewProgressDialogBinding

/**
* Custom progress dialog to display as alert during on long process user waiting.
Expand Down Expand Up @@ -58,8 +59,10 @@ class ProgressBarDialog(
setCanceledOnTouchOutside(false)
setCancelable(false)

viewBinding.isLoading = true
viewBinding.message = context.getString(messageRes)
viewBinding.progressBarLoading.visibility = View.VISIBLE
val message = context.getString(messageRes)
viewBinding.progressBarMessage.text = message
viewBinding.progressBarMessage.visibility = if (message.isEmpty()) View.GONE else View.VISIBLE
}

/**
Expand All @@ -73,7 +76,9 @@ class ProgressBarDialog(
setCanceledOnTouchOutside(true)
setCancelable(true)

viewBinding.isLoading = false
viewBinding.message = context.getString(messageRes)
viewBinding.progressBarLoading.visibility = View.GONE
val message = context.getString(messageRes)
viewBinding.progressBarMessage.text = message
viewBinding.progressBarMessage.visibility = if (message.isEmpty()) View.GONE else View.VISIBLE
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:background="@drawable/shape_progress_dialog"
android:padding="@dimen/progress_bar_container_padding">

<ProgressBar
android:id="@+id/progress_bar_loading"
android:layout_width="@dimen/progress_bar_loading_size"
android:layout_height="@dimen/progress_bar_loading_size"
app:layout_constraintBottom_toTopOf="@+id/progress_bar_message"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />

<androidx.appcompat.widget.AppCompatTextView
android:id="@+id/progress_bar_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/progress_bar_loading"
tools:text="Loading" />

</androidx.constraintlayout.widget.ConstraintLayout>
1 change: 0 additions & 1 deletion application/feature/characters/core/impl/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ impl(

target(":common:extensions:util"),
target(":common:extensions:android-util"),
target(":common:extensions:databinding-adapter"),
target(":common:util")

),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ impl(

target(":common:util"),
target(":common:extensions:android-util"),
target(":common:progressbar:databinding")
target(":common:progressbar:viewbinding")
)
)
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import by.kirich1409.viewbindingdelegate.viewBinding
import com.google.android.material.snackbar.Snackbar
import com.stepango.blockme.common.extensions.android.util.loadImage
import com.stepango.blockme.common.extensions.android.util.observe
import com.stepango.blockme.common.progressbar.databinding.ProgressBarDialog
import com.stepango.blockme.common.progressbar.viewbinding.ProgressBarDialog
import com.stepango.blockme.core.mvvm.library.ui.BaseViewBindingFragment
import com.stepango.blockme.core.mvvm.library.viewModels
import com.stepango.blockme.feature.characters.core.api.di.CharactersCoreFeatureProvider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ object versions {
const val coil = "2.1.0"

object jetbrains {
const val coroutines = "1.3.7"
const val coroutines = "1.6.1"
Jacks0N23 marked this conversation as resolved.
Show resolved Hide resolved
}

object androidx {
Expand Down
4 changes: 3 additions & 1 deletion plugins/android/src/main/java/viewBinding.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import tools.forma.android.feature.applyFeatures
import tools.forma.android.feature.kotlinAndroidFeatureDefinition
import tools.forma.owner.NoOwner
import tools.forma.owner.Owner
import tools.forma.android.target.AndroidUtilTargetTemplate
import tools.forma.android.target.ApiTargetTemplate
import tools.forma.android.target.LibraryTargetTemplate
import tools.forma.android.target.ResourcesTargetTemplate
Expand Down Expand Up @@ -53,7 +54,8 @@ fun Project.viewBinding(
ApiTargetTemplate,
WidgetTargetTemplate,
ResourcesTargetTemplate,
LibraryTargetTemplate
LibraryTargetTemplate,
AndroidUtilTargetTemplate,
),
dependencies = dependencies,
repositoriesConfiguration = Forma.configuration.repositories
Expand Down