Add manifest validation, replace manifest build dir generation #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # application/build.gradle.kts # plugins/build.gradle.kts
|
Oh! Nice PR, im waiting them for my project! |
stepango
reviewed
Nov 7, 2021
| """<?xml version="1.0" encoding="utf-8"?> | ||
| <manifest package="$packageName"/> | ||
| """.trimIndent() | ||
| """<manifest package="$packageName"/>""" |
There was a problem hiding this comment.
Why we are skipping xml version here?
There was a problem hiding this comment.
I've never seen any effect of specifying xml version in android xml files like manifest or resources, I can roll back this
stepango
reviewed
Nov 7, 2021
| private fun LibraryExtension.maybeGenerateManifest( | ||
| project: Project, | ||
| feature: AndroidLibraryFeatureConfiguration | ||
| ) { | ||
| val manifestFile = manifestFile(project.buildDir, feature.packageName) | ||
| val manifestFile = File(project.projectDir, "src/main/AndroidManifest.xml") |
There was a problem hiding this comment.
There could be a few cases where we'll need different manifests in src/smth folders do we want to support that?
stepango
previously approved these changes
Nov 7, 2021
michaem
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 flags to forma configuration for working with manifests:
generateManifestfrom android targets and addgenerateMissedManifeststo forma global configvalidateManifestPackagesfor comparing build.gradle.ktspackageNamewith manifest'spackage