fix(connectors): handle no results case from Stripe API list endpoints (

#306)
formancehq · Jan 31, 2025 · 4bb2363 · 4bb2363
1 parent 1dc8839
commit 4bb2363
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/internal/connectors/plugins/public/stripe/client/accounts.go b/internal/connectors/plugins/public/stripe/client/accounts.go
@@ -40,6 +40,10 @@ func (c *client) GetAccounts(
 
 	itr := c.accountClient.List(&stripe.AccountListParams{ListParams: filters})
 	results = append(results, itr.AccountList().Data...)
+	if len(results) == 0 {
+		return results, timeline, itr.AccountList().ListMeta.HasMore, wrapSDKErr(itr.Err())
+	}
+
 	timeline.LatestID = results[len(results)-1].ID
 	return results, timeline, itr.AccountList().ListMeta.HasMore, wrapSDKErr(itr.Err())
 }
diff --git a/internal/connectors/plugins/public/stripe/client/external_accounts.go b/internal/connectors/plugins/public/stripe/client/external_accounts.go
@@ -52,6 +52,9 @@ func (c *client) GetExternalAccounts(
 		return nil, timeline, false, wrapSDKErr(err)
 	}
 	results = append(results, itr.BankAccountList().Data...)
+	if len(results) == 0 {
+		return results, timeline, itr.BankAccountList().ListMeta.HasMore, nil
+	}
 	timeline.LatestID = results[len(results)-1].ID
 	return results, timeline, itr.BankAccountList().ListMeta.HasMore, nil
 }
diff --git a/internal/connectors/plugins/public/stripe/client/payments.go b/internal/connectors/plugins/public/stripe/client/payments.go
@@ -66,6 +66,10 @@ func (c *client) GetPayments(
 
 	itr := c.balanceTransactionClient.List(params)
 	results = append(results, itr.BalanceTransactionList().Data...)
+	if len(results) == 0 {
+		return results, timeline, itr.BalanceTransactionList().ListMeta.HasMore, wrapSDKErr(itr.Err())
+	}
+
 	timeline.LatestID = results[len(results)-1].ID
 	return results, timeline, itr.BalanceTransactionList().ListMeta.HasMore, wrapSDKErr(itr.Err())
 }