Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sic to Rust edition 2021 #1068

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Upgrade sic to Rust edition 2021 #1068

merged 4 commits into from
Feb 1, 2022

Conversation

foresterre
Copy link
Owner

@foresterre foresterre commented Feb 1, 2022

With a new edition also comes a new MSRV, namely Rust 1.56, the first release which added support for edition 2021.

In addition, the new MSRV is necessary for image 0.24:

image-rs/image#1433
https://github.com/image-rs/image/blob/master/CHANGES.md

@foresterre
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Feb 1, 2022
1068: Upgrade sic to Rust edition 2021 r=foresterre a=foresterre

With a new edition also comes a new MSRV, namely Rust 1.56, the first release which added support for edition 2021.

Co-authored-by: Martijn Gribnau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 1, 2022

Build failed:

With a new edition comes a new MSRV, namely Rust 1.56, the first release which added support for edition 2021.
@foresterre
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Feb 1, 2022
1068: Upgrade sic to Rust edition 2021 r=foresterre a=foresterre

With a new edition also comes a new MSRV, namely Rust 1.56, the first release which added support for edition 2021.

In addition, the new MSRV is necessary for image 0.24:

image-rs/image#1433
https://github.com/image-rs/image/blob/master/CHANGES.md

Co-authored-by: Martijn Gribnau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 1, 2022

Build failed:

@foresterre
Copy link
Owner Author

bors r+

@bors bors bot merged commit 1e0be37 into main Feb 1, 2022
@foresterre foresterre deleted the edition2021 branch February 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant