Skip to content

Commit

Permalink
fix: limit CSB sourcepath with metadata.excluded
Browse files Browse the repository at this point in the history
  • Loading branch information
WillieRuemmele committed Feb 5, 2025
1 parent 68c3a4e commit ac40090
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/collections/componentSetBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ export class ComponentSetBuilder {
fsPaths,
registry,
});
if (metadata?.excludedEntries) {
const toRemove = metadata.excludedEntries
.map(entryToTypeAndName(registry))
.flatMap(typeAndNameToMetadataComponents({ directoryPaths: fsPaths, registry }));
componentSet = componentSet.filter((md) => !toRemove.includes(md));
}
}

// Return empty ComponentSet and use packageNames in the connection via `.retrieve` options
Expand Down

2 comments on commit ac40090

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: ac40090 Previous: e292796 Ratio
eda-componentSetCreate-linux 230 ms 228 ms 1.01
eda-sourceToMdapi-linux 2064 ms 2069 ms 1.00
eda-sourceToZip-linux 1892 ms 1878 ms 1.01
eda-mdapiToSource-linux 2683 ms 2680 ms 1.00
lotsOfClasses-componentSetCreate-linux 488 ms 477 ms 1.02
lotsOfClasses-sourceToMdapi-linux 3752 ms 3633 ms 1.03
lotsOfClasses-sourceToZip-linux 3164 ms 2908 ms 1.09
lotsOfClasses-mdapiToSource-linux 3602 ms 3494 ms 1.03
lotsOfClassesOneDir-componentSetCreate-linux 828 ms 815 ms 1.02
lotsOfClassesOneDir-sourceToMdapi-linux 6413 ms 6365 ms 1.01
lotsOfClassesOneDir-sourceToZip-linux 5097 ms 5196 ms 0.98
lotsOfClassesOneDir-mdapiToSource-linux 6355 ms 6420 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: ac40090 Previous: e292796 Ratio
eda-componentSetCreate-win32 709 ms 625 ms 1.13
eda-sourceToMdapi-win32 4122 ms 3810 ms 1.08
eda-sourceToZip-win32 3286 ms 3011 ms 1.09
eda-mdapiToSource-win32 5797 ms 5457 ms 1.06
lotsOfClasses-componentSetCreate-win32 1435 ms 1356 ms 1.06
lotsOfClasses-sourceToMdapi-win32 8351 ms 7810 ms 1.07
lotsOfClasses-sourceToZip-win32 4825 ms 5145 ms 0.94
lotsOfClasses-mdapiToSource-win32 7671 ms 7745 ms 0.99
lotsOfClassesOneDir-componentSetCreate-win32 2281 ms 2309 ms 0.99
lotsOfClassesOneDir-sourceToMdapi-win32 13385 ms 13841 ms 0.97
lotsOfClassesOneDir-sourceToZip-win32 8339 ms 8832 ms 0.94
lotsOfClassesOneDir-mdapiToSource-win32 13606 ms 13977 ms 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.