Skip to content

Commit

Permalink
fix: check for sourcepath length
Browse files Browse the repository at this point in the history
  • Loading branch information
@shetzel
shetzel committed Feb 6, 2025
1 parent 7cec15a commit 932992e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/collections/componentSetBuilder.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class ComponentSetBuilder {

// Resolve metadata entries with source in package directories, unless we are building a ComponentSet
// from metadata in an org.
if (metadata && !org && !sourcepath) {
if (metadata && !org && !sourcepath?.length) {
getLogger().debug(`Building ComponentSet from metadata: ${metadata.metadataEntries.toString()}`);
const directoryPaths = metadata.directoryPaths;
componentSet ??= new ComponentSet(undefined, registry);
Expand Down

2 comments on commit 932992e

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 932992e Previous: 7cec15a Ratio
eda-componentSetCreate-linux 222 ms 262 ms 0.85
eda-sourceToMdapi-linux 2051 ms 2361 ms 0.87
eda-sourceToZip-linux 1866 ms 2249 ms 0.83
eda-mdapiToSource-linux 3585 ms 3014 ms 1.19
lotsOfClasses-componentSetCreate-linux 480 ms 545 ms 0.88
lotsOfClasses-sourceToMdapi-linux 3709 ms 4027 ms 0.92
lotsOfClasses-sourceToZip-linux 2916 ms 3528 ms 0.83
lotsOfClasses-mdapiToSource-linux 3487 ms 3893 ms 0.90
lotsOfClassesOneDir-componentSetCreate-linux 819 ms 947 ms 0.86
lotsOfClassesOneDir-sourceToMdapi-linux 6410 ms 7223 ms 0.89
lotsOfClassesOneDir-sourceToZip-linux 5173 ms 6284 ms 0.82
lotsOfClassesOneDir-mdapiToSource-linux 6281 ms 7181 ms 0.87

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 932992e Previous: 7cec15a Ratio
eda-componentSetCreate-win32 700 ms 682 ms 1.03
eda-sourceToMdapi-win32 4167 ms 4914 ms 0.85
eda-sourceToZip-win32 3361 ms 3338 ms 1.01
eda-mdapiToSource-win32 5833 ms 6136 ms 0.95
lotsOfClasses-componentSetCreate-win32 1439 ms 1476 ms 0.97
lotsOfClasses-sourceToMdapi-win32 8248 ms 8301 ms 0.99
lotsOfClasses-sourceToZip-win32 5193 ms 5230 ms 0.99
lotsOfClasses-mdapiToSource-win32 8207 ms 8320 ms 0.99
lotsOfClassesOneDir-componentSetCreate-win32 2484 ms 2493 ms 1.00
lotsOfClassesOneDir-sourceToMdapi-win32 14638 ms 14913 ms 0.98
lotsOfClassesOneDir-sourceToZip-win32 9351 ms 8870 ms 1.05
lotsOfClassesOneDir-mdapiToSource-win32 14997 ms 13967 ms 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.