Upgrades: add batch updates for larger upgrades when updating tens of…

… thousands of jobs.
forcedotcom · Aug 5, 2021 · 3fb7ad4 · 3fb7ad4
1 parent 06423c9
commit 3fb7ad4
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/api/orgpackageversions.js b/api/orgpackageversions.js
@@ -98,7 +98,18 @@ async function insertOrgPackageVersions(opvs) {
 	return db.insert(sql, values);
 }
 
-async function updateOrgPackageVersions(opvs) {
+async function updateOrgPackageVersions(opvs, batchSize = 2000) {
+	const count = opvs.length;
+	for (let start = 0; start < count;) {
+		try {
+			await updateOrgPackageVersionsBatch(opvs.slice(start, start += batchSize));
+		} catch (e) {
+			logger.error(e);
+		}
+	}
+}
+
+async function updateOrgPackageVersionsBatch(opvs) {
 	let n = 0;
 	let params = [];
 	let values = [];
@@ -141,4 +152,4 @@ exports.findAll = findAll;
 exports.insertOrgPackageVersions = insertOrgPackageVersions;
 exports.updateOrgPackageVersions = updateOrgPackageVersions;
 exports.updateFromLicenseStatus = updateFromLicenseStatus;
-exports.updateStatus = updateStatus;
+exports.updateStatus = updateStatus;
diff --git a/api/upgrades.js b/api/upgrades.js
@@ -457,7 +457,18 @@ async function updateUpgradeItemStatus(updated) {
 	await db.update(sql, values);
 }
 
-async function updateUpgradeJobsStatus(jobs) {
+async function updateUpgradeJobsStatus(jobs, batchSize = 2000) {
+	const count = jobs.length;
+	for (let start = 0; start < count;) {
+		try {
+			await updateUpgradeJobsStatusBatch(jobs.slice(start, start += batchSize));
+		} catch (e) {
+			logger.error(e);
+		}
+	}
+}
+
+async function updateUpgradeJobsStatusBatch(jobs) {
 	let n = 0;
 	let params = [];
 	let values = [];