Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(W-16301365): update node to v20 + bunch of deps #606

Merged
merged 7 commits into from
Mar 11, 2025
Merged

chore(W-16301365): update node to v20 + bunch of deps #606

merged 7 commits into from
Mar 11, 2025

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Mar 8, 2025 •
edited
Loading

What does this PR do?

  • Updates node to v20
  • Updates @lwc/* to latest
  • Updates many dependencies to latest
  • Fixes jest config to get rid of a warning from testUrl deprecated

What issues does this PR fix or reference?

@W-16301365@

@CristiCanizales CristiCanizales self-assigned this Mar 8, 2025
@CristiCanizales CristiCanizales requested a review from a team as a code owner March 8, 2025 04:27
@CristiCanizales CristiCanizales requested a review from randi274 March 8, 2025 04:27
@CristiCanizales CristiCanizales requested review from peternhale, mingxuanzhangsfdx, daphne-sfdc and madhur310 and removed request for randi274 March 8, 2025 05:16
@CristiCanizales CristiCanizales changed the title chore(W-16301365): update to node 20 + all lwc deps chore(W-16301365): update node to v20 + bunch of deps Mar 8, 2025
mingxuanzhangsfdx
mingxuanzhangsfdx approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@mingxuanzhangsfdx mingxuanzhangsfdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Tested the change in extensions and language server functions such as hovering over, auto completion, go to definition all work

@CristiCanizales CristiCanizales merged commit 5982156 into main Mar 11, 2025
8 checks passed
@CristiCanizales CristiCanizales deleted the cristi/nodeUpdate branch March 11, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxuanzhangsfdx mingxuanzhangsfdx mingxuanzhangsfdx approved these changes

@peternhale peternhale Awaiting requested review from peternhale

@daphne-sfdc daphne-sfdc Awaiting requested review from daphne-sfdc

@madhur310 madhur310 Awaiting requested review from madhur310

Assignees

@CristiCanizales CristiCanizales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CristiCanizales @mingxuanzhangsfdx