Update SDK to automatically pull runtime URL when a session starts #28
Conversation
src/main/java/com/salesforce/einsteinbot/sdk/client/BasicChatbotClientImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/com/salesforce/einsteinbot/sdk/client/BasicChatbotClientTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/salesforce/einsteinbot/sdk/client/BasicChatbotClientImpl.java
Outdated
Show resolved
Hide resolved
| return Optional.ofNullable(val); | ||
| } | ||
|
|
||
| public Optional<Object> getObject(String key) { |
There was a problem hiding this comment.
What would help here is to turn the Cache into a generic Cache<T>. That would let you avoid using the concrete type in BaseChatbotClientImpl and creating the set/getObject methods.
There was a problem hiding this comment.
Agree, we can make to use generic type.
| this.basePath = basePath; | ||
| this.webClientBuilder = webClientBuilder; | ||
| this.clientWrapper = ClientFactory.createClient(basePath, webClientBuilder); | ||
| this.cache = new InMemoryCache(DEFAULT_TTL_SECONDS); |
There was a problem hiding this comment.
See note about making Cache generic here, then you can just have a protected Cache<Object> cache and handle the casting on a per-key basis (or create a POJO to store if you want to avoid casing between String|Object)
There was a problem hiding this comment.
Don't think we want to hardcode to InMemoryCache , it's better allow user to provide cache implementation.
src/main/java/com/salesforce/einsteinbot/sdk/client/BasicChatbotClientImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/salesforce/einsteinbot/sdk/client/BasicChatbotClientImpl.java
Outdated
Show resolved
Hide resolved
| return Optional.ofNullable(val); | ||
| } | ||
|
|
||
| public Optional<Object> getObject(String key) { |
There was a problem hiding this comment.
Agree, we can make to use generic type.
| @@ -25,7 +25,7 @@ public class RedisCache implements Cache { | |||
| private static final Long DEFAULT_TTL_SECONDS = 259140L; // 2 days, 23 hours, 59 minutes | |||
|
|
|||
| private JedisPool jedisPool; | |||
| private long ttlSeconds; | |||
| private final long ttlSeconds; | |||
There was a problem hiding this comment.
I think we should also support storing/retrieving objects in RedisCache implementation.
| this.basePath = basePath; | ||
| this.webClientBuilder = webClientBuilder; | ||
| this.clientWrapper = ClientFactory.createClient(basePath, webClientBuilder); | ||
| this.cache = new InMemoryCache(DEFAULT_TTL_SECONDS); |
There was a problem hiding this comment.
Don't think we want to hardcode to InMemoryCache , it's better allow user to provide cache implementation.
bharatsuri97
force-pushed
the
update-sdk-pull-runtime-url-dynamically
branch
from
5091e11 to
94017a6
Compare
bharatsuri97
force-pushed
the
update-sdk-pull-runtime-url-dynamically
branch
2 times, most recently
from
9f027e2 to
4ee9ac9
Compare
bharatsuri97
force-pushed
the
update-sdk-pull-runtime-url-dynamically
branch
from
4ee9ac9 to
b8a9c37
Compare
No description provided.