refactor name checks (attempt 2) #3800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks rather snazzy as markdown.
obvs I will add the actual names of each nameID. |
Closed
m4rc1e
force-pushed
the
name-checks2
branch
3 times, most recently
from
d256c1b to
cc28cfc
Compare
|
Cool! thanks Felipe. I'm just wrapping up here. I've decided to parametrize the old tests and keep em in for safety reasons. Hoping to be done by today. |
m4rc1e
commented
Jun 24, 2022
|
@felipesanches I guess this is ready for a first review. Since I've just parametrised the old name checks, I don't think we need a hangout where I try and convince you to merge this ;-). |
felipesanches
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Jun 28, 2022
felipesanches
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Jun 28, 2022
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this pull request
Jun 28, 2022
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this pull request
Jun 28, 2022
m4rc1e
added a commit
to felipesanches/fontbakery
that referenced
this pull request
Jul 28, 2022
m4rc1e
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Jul 28, 2022
felipesanches
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Aug 2, 2022
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this pull request
Aug 2, 2022
felipesanches
pushed a commit
that referenced
this pull request
Aug 2, 2022
felipesanches
added a commit
that referenced
this pull request
Aug 2, 2022
3 tasks
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the name checks we currently have by using the name builders found in the axis registry, googlefonts/axisregistry#31. It will also check the fvar instances and stat entries.
I've decided to group the checks together and display the information as tables.
@felipesanches still wip but getting there. My aim is to keep the existing tests so we know we're safe. The name builders also have extensive tests, https://github.com/googlefonts/axisregistry/blob/main/tests/test_names.py
To Do
CHANGELOG.md