-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OFL website has a new URL and FontBakery should be aware of it #4358
Comments
Ideally the new URL should be accepted but also a WARN emitted when the old one is found with a suggestion to move to the new URL. We (SIL) have put redirects in place from the old to the new URL and they will probably be around for a good while but users should start moving to the new URL when they get a chance. |
I have the beginning of a check for that. I'm learning the subtleties of FontBakery, but I'm not able to figure out how to have a check be only a family or repo check. IOW it's giving me the results for all the fonts in the folder so the report info is duplicated, any pointers, thanks. |
Cool! Please submit your work-in-progress as a pull request and I can help you improve it. |
I believe you can pass |
Thanks, I will prep the PR very soon. I really appreciate all your work on FontBakery! In our current workflow we run FontBakery with a wildcard over all generated fonts in a single project, so even if I use |
I've just amended the license_url check so a warn is raised if the old url is used, b297247 |
New OFL website URL is expected, while the old one emits a WARN com.google.fonts/check/name/license_url On the Google Fonts Profile (issue #4358)
thanks, everybody ;-) |
New OFL website URL is expected, while the old one emits a WARN com.google.fonts/check/name/license_url On the Google Fonts Profile (issue #4358)
Hi @n7s, any progress on that PR? If you want to put up what you have, I would be happy to take it over. |
Sorry, we're fine, the PR from Dave got merged before I saw this. |
According to google/fonts#7062, FontBakery checks should accept the new URL for the OFL website.
The text was updated successfully, but these errors were encountered: