Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com.google.fonts/metadata/fontname_not_camel_cased] expand check into general GF family name compliance #4049

Closed
yanone opened this issue Feb 3, 2023 · 0 comments · Fixed by #4050
Assignees
Milestone

Comments

@yanone
Copy link
Collaborator

yanone commented Feb 3, 2023

I'm going to rewrite the metadata/fontname_not_camel_cased check and make it into a name table check because I need this to be flagged when I work on it (when METADATA.pb doesn't exist yet usually), not when it's PR'd to GF (when it does exist).

In the same wake I want to expand the scope of the check to make sure the name complies with the guide. Here's what I infer from it:

  • Allowed characters: A-Za-z0-9 and space
  • Must start with A-Z
  • No CamelCase
  • No initials (like "PT Sans")
  • (I'm not going to implement the "no references to languages or writing systems" rule)

And then the Guide says "no diacritics". Are we sure about that? No "Moiré", no "Straße", no "Fantômas"?
I mean, I scrolled GF manually half-way through and indeed couldn't find a single non-ASCII character in names, but still I need to ask.

Also I would create a known exception file again for abbreviations like we already have it for CamelCase names and put IBM, PT, SIL etc in it, but keep it concise.

The new check now finds a whole bunch of instances in the GF library where family names are written without spaces (=CamelCased) in the name table but with spaces in METADATA.pb (only guessing that this is the situation, I confirmed some names to be correctly displayed on fonts.google.com)

@yanone yanone linked a pull request Feb 3, 2023 that will close this issue
3 tasks
@yanone yanone self-assigned this Feb 3, 2023
@felipesanches felipesanches added this to the 0.8.11 milestone Feb 8, 2023
@felipesanches felipesanches reopened this Feb 8, 2023
felipesanches pushed a commit to felipesanches/fontbakery that referenced this issue Feb 15, 2023
Renamed check ID on Google Fonts profile:
com.google.fonts/check/metadata/fontname_not_camel_cased
=> com.google.fonts/check/name/family_name_compliance

(issue fonttools#4049)
felipesanches pushed a commit to felipesanches/fontbakery that referenced this issue Feb 15, 2023
Renamed check ID on Google Fonts profile:
com.google.fonts/check/metadata/fontname_not_camel_cased
=> com.google.fonts/check/name/family_name_compliance

(issue fonttools#4049)
felipesanches pushed a commit that referenced this issue Feb 15, 2023
Renamed check ID on Google Fonts profile:
com.google.fonts/check/metadata/fontname_not_camel_cased
=> com.google.fonts/check/name/family_name_compliance

(issue #4049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants