Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com.google.fonts/check/vendor_id] warn if PYRS is the Vendor ID #3943

Closed
glenda-tn opened this issue Nov 7, 2022 · 1 comment
Closed

[com.google.fonts/check/vendor_id] warn if PYRS is the Vendor ID #3943

glenda-tn opened this issue Nov 7, 2022 · 1 comment
Assignees
@felipesanches
Labels
Check improvement proposal P0 Urgent
Milestone
0.8.11

Comments

@glenda-tn
Copy link

glenda-tn commented Nov 7, 2022 •
edited by felipesanches
Loading

com.google.fonts/check/vendor_id

Observed behaviour

Vendor ID check passes if PYRS is used, but this is the default for [PYRS Fontlab Ltd. / Made with FontLab].

Expected behaviour

Check should WARN and advise to check the Vendor ID since PYRS is a default entry from FontLab generated binaries.

Resources and exact process needed to replicate

(Please provide here an URL to a font file that appears to cause the issue, and the exact steps from updating to the latest code on the main branch to reproduce the Observed Behaviour. We need this in for replicating the issue and fixing it :)
@felipesanches felipesanches self-assigned this Nov 8, 2022
@felipesanches felipesanches added this to the 0.8.11 milestone Nov 8, 2022
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 15, 2022
@felipesanches
PYRS is a default Vendor ID entry from FontLab generated binaries.
bf86ced 
com.google.fonts/check/vendor_id
(issue fonttools#3943)
@felipesanches felipesanches mentioned this issue Nov 15, 2022
Merged
felipesanches added a commit that referenced this issue Nov 15, 2022
@felipesanches
PYRS is a default Vendor ID entry from FontLab generated binaries.
a1906f5 
com.google.fonts/check/vendor_id
(issue #3943)
@glenda-tn
Copy link
Author

Thank you @felipesanches!

@vv-monsalve vv-monsalve mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
Check improvement proposal P0 Urgent
Projects
None yet
Milestone
0.8.11
Development

No branches or pull requests
2 participants
@felipesanches @glenda-tn