Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check: If hinted, check fonts have head table flag bit 3 set #2338

Closed
davelab6 opened this issue Feb 7, 2019 · 4 comments
Closed

Add check: If hinted, check fonts have head table flag bit 3 set #2338

davelab6 opened this issue Feb 7, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@davelab6
Copy link
Contributor

davelab6 commented Feb 7, 2019

Observed behaviour

Per https://docs.microsoft.com/en-us/typography/opentype/spec/head, bit 3 of Head::flags decides whether PPEM should be rounded. This bit should always be set for hinted fonts. We do not have a check for this.

Expected behaviour

We have a check for this.

@davelab6 davelab6 added this to the 0.6.11 milestone Feb 7, 2019
@felipesanches felipesanches modified the milestones: 0.6.11, 0.6.10 Feb 7, 2019
@felipesanches felipesanches self-assigned this Feb 7, 2019
@felipesanches felipesanches modified the milestones: 0.6.10, 0.6.11 Feb 11, 2019
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Feb 12, 2019
"PPEM must be an integer on hinted fonts."
(issue fonttools#2338)
felipesanches added a commit that referenced this issue Feb 12, 2019
"PPEM must be an integer on hinted fonts."
(issue #2338)
@felipesanches
Copy link
Collaborator

@davelab6, @m4rc1e, @laerm0:
This is the current state of the OFL licenced portion of the Google Fonts collection regarding this new check:

screenshot at 2019-02-12 17 51 31

Notes:

  • SKIP means the font is not hinted. Detection is based on the presence of a "fpgm" (Font Program) table.
  • PASS means the font is hinted and has bit 3 of the head table flags properly set.
  • FAIL means the font is hinted but does not set the bit.

@felipesanches
Copy link
Collaborator

@davelab6 would you prefer if I opened an issue on google/fonts issue tracker with this kind of collection-wide overview whenever a new check is implemented in fontbakery?

@laerm0
Copy link

laerm0 commented Feb 12, 2019

I'm glad to know our collection is so colorful.

@thundernixon
Copy link
Contributor

I've just come across this while rebuilding Encode with the latest FB. Does anyone know if this can be set in GlyphsApp, or if there's an existing GFtools script to set this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants