-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate JuliaSyntax.jl #2526
integrate JuliaSyntax.jl #2526
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="julia_syntax")
julia> using Pluto |
JuliaLang/julia#46372 has been merged 🎊 and JuliaSyntax will become the default parser in 1.10 ! I will come back to this PR and probably drop the JuliaSyntax dependency (make it work only on >=1.10 or with JuliaSyntax + |
The last problem is z-index positioning of the tooltip which is wrong when the cell is not in focus or with the run button. I tried setting the The same problem happens with autocompletion tooltip but it is less of a problem (notice the run button over): Pinging CSS Expert @pankgeorg, you may have an idea on how to fix that ? 😃 |
I found a solution for the z-index problem above in c45201b. This PR is now ready! |
One future improvement is identifying error messages we can propose quick fixes for (like "replace I am going to merge once the CI pass as it only affects 1.10 users for now (and slightly improves the display of syntax errors for VERSION < 1.10). |
ParseError <: ReactivityError
and usingrelay_reactivity_error!
.