fix(hacks): remove redundancies in show_cursor
#870
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was constantly running into the issue of my cursor disappearing. To get it back, I had to manually(or via a dedicated au) re-set the
gcr/guicursor
setting.Checking the code, I see you have some redundant checks for the same condition.
if M._guicursor
andif not Util.is_exiting()
are both check inside and outside of the scheduled function.The removed double checks should also result in a minor improvement reducing load.
This fix can also help with the reports that people still experience #114.