Skip to content

Commit

Permalink
fix(nui): umount on hide, to fix rendering issue while blocking
Browse files Browse the repository at this point in the history
  • Loading branch information
folke committed Nov 11, 2022
1 parent 3489e57 commit 119682b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lua/noice/view/nui.lua
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ function NuiView:create()
padding = Util.nui.normalize_padding(self._opts.border),
})
self._scroll:mount()
-- NOTE: this is needed, to make sure the border is rendered properly during blocking events
self._loading = false
end

Expand Down Expand Up @@ -186,7 +185,7 @@ function NuiView:hide()
Util.protect(function()
if self._nui and not self._visible then
self:clear()
self._nui:hide()
self._nui:unmount()
self._scroll:hide()
end
end, {
Expand Down

0 comments on commit 119682b

Please sign in to comment.