We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit 554a005 introduced a bug that sometimes causes crash - it may be return undefined.
undefined
For example: This lines: https://github.com/devongovett/fontkit/blob/08171fe567b4922325bcd5a268e238501624b890/src/opentype/OTProcessor.js#L237-L240 When glyph is 3 and classDef.startGlyph is 4. Variable i will be -1. Condition will be valid and will be returned index -1 from array which will undefined. And this causes an error in the other methods. Probably there should be something like: if (i > -1 && i < classDef.classValueArray.length) {
glyph
3
classDef.startGlyph
4
i
-1
if (i > -1 && i < classDef.classValueArray.length) {
I do not know exactly how it should work, but condition for negative number i do not return true.
This bug causes crash in https://github.com/bpampuch/pdfmake when I use any font.
The text was updated successfully, but these errors were encountered:
temporary bugfix for fontkit version 1.5.2 - issue foliojs/fontkit#65
b910054
I applied your fix in 26f99b8, and released in v1.5.4. Would like to add a test case for that. Do you have a font that causes this error?
Sorry, something went wrong.
@devongovett Thanks.
Font causes error can download here: https://github.com/bpampuch/pdfmake/blob/880db373839b3f51eae29259ea93da9afdb99429/examples/fonts/Roboto-Regular.ttf
No branches or pull requests
Commit 554a005 introduced a bug that sometimes causes crash - it may be return
undefined
.For example:
This lines: https://github.com/devongovett/fontkit/blob/08171fe567b4922325bcd5a268e238501624b890/src/opentype/OTProcessor.js#L237-L240
When
glyph
is3
andclassDef.startGlyph
is4
. Variablei
will be-1
.Condition will be valid and will be returned index -1 from array which will
undefined
. And this causes an error in the other methods.Probably there should be something like:
if (i > -1 && i < classDef.classValueArray.length) {
I do not know exactly how it should work, but condition for negative number
i
do not return true.This bug causes crash in https://github.com/bpampuch/pdfmake when I use any font.
The text was updated successfully, but these errors were encountered: