Fix package title selection tests

folio-org · Oct 19, 2017 · 30cd158 · 30cd158
1 parent e1ad22f
commit 30cd158
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 12 deletions.
diff --git a/src/components/customer-resource-show.js b/src/components/customer-resource-show.js
@@ -95,7 +95,10 @@ export default function CustomerResourceShow({ customerResource, toggleRequest,
 
               <hr />
 
-              <label htmlFor="customer-resource-show-toggle-switch">
+              <label
+                data-test-eholdings-customer-resource-show-selected
+                htmlFor="customer-resource-show-toggle-switch"
+              >
                 <h4>{record.isSelected ? 'Selected' : 'Not Selected'}</h4>
                 <ToggleSwitch
                   onChange={toggleSelected}

diff --git a/src/components/toggle-switch/toggle-switch.js b/src/components/toggle-switch/toggle-switch.js
@@ -7,9 +7,11 @@ const cx = classNames.bind(styles);
 
 export default function ToggleSwitch(props) {
   return (
-    <div className={cx(styles['toggle-switch'], {
-      'is-pending': props.isPending
-    })}
+    <div
+      data-test-toggle-switch
+      className={cx(styles['toggle-switch'], {
+        'is-pending': props.isPending
+      })}
     >
       <input
         type="checkbox"
@@ -30,4 +32,3 @@ ToggleSwitch.propTypes = {
   isPending: PropTypes.bool,
   id: PropTypes.string
 };
-
diff --git a/tests/customer-resource-show-test.js b/tests/customer-resource-show-test.js
@@ -5,7 +5,7 @@ import it from './it-will';
 import { describeApplication } from './helpers';
 import ResourcePage from './pages/customer-resource-show';
 
-describeApplication('CustomerResourceShow', () => {
+describeApplication.only('CustomerResourceShow', () => {
   let vendor,
     vendorPackage,
     resource;
@@ -76,7 +76,7 @@ describeApplication('CustomerResourceShow', () => {
       expect(ResourcePage.isSelected).to.equal(false);
     });
 
-    describe('selecting a package title to add to my holdings', () => {
+    describe('successfully selecting a package title to add to my holdings', () => {
       beforeEach(function () {
         /*
          * The expectations in the convergent `it` blocks
@@ -95,7 +95,7 @@ describeApplication('CustomerResourceShow', () => {
         this.server.timing = 0;
       });
 
-      it('reflects the desired state (YES)', () => {
+      it('reflects the desired state (Selected)', () => {
         expect(ResourcePage.isSelected).to.equal(true);
       });
 
@@ -116,9 +116,38 @@ describeApplication('CustomerResourceShow', () => {
           expect(ResourcePage.isSelecting).to.equal(false);
         });
       });
+    });
+
+    describe('unsuccessfully selecting a package title to add to my holdings', () => {
+      beforeEach(function () {
+        this.server.put('/vendors/:vendorId/packages/:packageId/titles/:titleId', [{
+          message: 'There was an error',
+          code: '1000',
+          subcode: 0
+        }], 500);
+
+        this.server.timing = 50;
+        return ResourcePage.toggleIsSelected();
+      });
+
+      afterEach(function () {
+        this.server.timing = 0;
+      });
+
+      it('reflects the desired state (Selected)', () => {
+        expect(ResourcePage.isSelected).to.equal(true);
+      });
+
+      it('indicates it working to get to desired state', () => {
+        expect(ResourcePage.isSelecting).to.equal(true);
+      });
 
-      describe('when the request fails', () => {
-        it('does not change to new state', () => {
+      it('cannot be interacted with while the request is in flight', () => {
+        expect(ResourcePage.isSelectedToggleable).to.equal(false);
+      });
+
+      describe('when the request succeeds', () => {
+        it('reflect the desired state was set', () => {
           expect(ResourcePage.isSelected).to.equal(false);
         });
 

diff --git a/tests/pages/customer-resource-show.js b/tests/pages/customer-resource-show.js
@@ -44,7 +44,7 @@ export default {
   },
 
   get isSelected() {
-    return $('[data-test-eholdings-customer-resource-show-selected]').text() === 'Yes';
+    return $('[data-test-eholdings-customer-resource-show-selected]').text() === 'Selected';
   },
 
   toggleIsSelected() {
@@ -60,7 +60,7 @@ export default {
   },
 
   get isSelecting() {
-    return $('[data-test-eholdings-customer-resource-show-is-selecting]').length > 0;
+    return $('[data-test-eholdings-customer-resource-show-selected] [data-test-toggle-switch]').attr('class').indexOf('is-pending--') !== -1;
   },
 
   get isSelectedToggleable() {