Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERM-3297 Block save on invalid date in agreement edit #699

Merged
merged 6 commits into from
Sep 18, 2024
Merged

ERM-3297 Block save on invalid date in agreement edit #699

merged 6 commits into from
Sep 18, 2024

Conversation

CalamityC
Copy link
Contributor

  • add datePlausibilityCheck to validators

@CalamityC
ERM-3297 Block save on invalid date in agreement edit
ab3fae6 
* add datePlausibilityCheck to validators
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    37 suites  ±0   2m 56s ⏱️ -1s
263 tests ±0  262 ✔️  - 1  1 💤 +1  0 ❌ ±0 
270 runs  ±0  269 ✔️  - 1  1 💤 +1  0 ❌ ±0 

Results for commit 4eff4aa. ± Comparison against base commit b4d5ed7.

♻️ This comment has been updated with latest results.

@CalamityC
* fix OrganizationSelectionDisplay.test.js
4eff4aa 
* skip 'renders expected open menu button' test in Tags.test.js
@CalamityC CalamityC marked this pull request as ready for review September 4, 2024 15:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Jest Unit Test Results

  1 files  ±0   37 suites  ±0   1m 10s ⏱️ +2s
263 tests ±0  263 ✅ ±0  0 💤 ±0  0 ❌ ±0 
264 runs  ±0  264 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2c8d02e. ± Comparison against base commit 8a5f180.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@EthanFreestone EthanFreestone merged commit dc404b6 into master Sep 18, 2024
15 checks passed
@EthanFreestone EthanFreestone deleted the erm-3297 branch September 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanFreestone EthanFreestone EthanFreestone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalamityC @EthanFreestone