Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okapi interface is a normal interface OKAPI-1199 #1370

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

adamdickmeiss
Copy link
Contributor

Before this commit, modules could not really require the interface as it was not considered in dependency resolution (install).

Before this commit, modules could not really require the interface
as it was not considered in dependency resolution (install).
@jakub-id jakub-id self-requested a review January 28, 2025 13:16
doc/guide.md Outdated Show resolved Hide resolved
Co-authored-by: julianladisch <[email protected]>
Copy link
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@adamdickmeiss
Copy link
Contributor Author

Looks good, thanks!

Ty too.

@adamdickmeiss adamdickmeiss merged commit 4076ffd into master Jan 28, 2025
5 checks passed
@adamdickmeiss adamdickmeiss deleted the OKAPI-1199-okapi-interface-type branch January 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants