improve perf for default_signer: Don't create new PKey::RSA if we already can sign #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of today we creating new `OpenSSL::PKey::RSA` when we sign, even if the existing `signing_key` is already a `OpenSSL::PKey::RSA`. In google ruby gem they are doing the same approach - https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-storage/lib/google/cloud/storage/file/signer_v2.rb#L137 ``` Warming up -------------------------------------- sign 119.000 i/100ms new 179.000 i/100ms Calculating ------------------------------------- sign 1.199k (± 0.7%) i/s - 6.069k in 5.063095s new 1.791k (± 0.6%) i/s - 9.129k in 5.096376s Comparison: new: 1791.3 i/s sign: 1198.7 i/s - 1.49x slower ``` source: https://gist.github.com/yosiat/372bc468d23c568cd8722af7f56a2b03
|
@geemus Can you review this PR? |
geemus
approved these changes
Apr 21, 2023
|
Thanks! |
|
Released in v1.20.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today we creating new
OpenSSL::PKey::RSAwhen we sign, even if the existingsigning_keyis already aOpenSSL::PKey::RSA.In google ruby gem they are doing the same approach - https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-storage/lib/google/cloud/storage/file/signer_v2.rb#L137
source: https://gist.github.com/yosiat/372bc468d23c568cd8722af7f56a2b03