Fix get_object not working with binary files #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
commented
Jun 23, 2021
The change in fog#521 caused the `Tempfile` buffer to be used, which opens a file in ASCII mode by default. We need to make use of `binmode` to activate binary streams.
stanhu
force-pushed
the
sh-fix-get-object-binmode
branch
from
1ff0f38 to
f27a861
Compare
geemus
approved these changes
Jun 24, 2021
|
Fix released in v1.15.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #521 caused the
Tempfilebuffer to be used, which opensa file in ASCII mode by default. We need to make use of
binmodetoactivate binary streams.
Closes #533