-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing SQLv1 API support + small SQL model fixes #493
Conversation
Support for First Generation instances ended January 30, 2020 and you no longer can create First Generation instances. See: https://cloud.google.com/sql/docs/mysql/upgrade-2nd-gen
@icco I'm not going to break compatibility, but I am planning to remove the CI, tests and any first-tier exclusive methods as they're going to be unusable. You reckon this should be a minor or a major version release? |
Minor I think is reasonable |
Now it actually tracks the operation in progress, so we don't get Google::Apis::ClientError: operationInProgress if we try to touch the instance immediately after.
- Restructured tests and removed v1-specific ones - Updated test factories - Updated examples
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 87.94% 89.01% +1.06%
==========================================
Files 340 340
Lines 5659 5661 +2
==========================================
+ Hits 4977 5039 +62
+ Misses 682 622 -60
Continue to review full report at Codecov.
|
Support for First Generation instances ended January 30, 2020 and you no longer can create First Generation instances.
See: https://cloud.google.com/sql/docs/mysql/upgrade-2nd-gen