Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SQLv1 API support + small SQL model fixes #493

Merged
merged 5 commits into from
Mar 27, 2020

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Mar 26, 2020

Support for First Generation instances ended January 30, 2020 and you no longer can create First Generation instances.

See: https://cloud.google.com/sql/docs/mysql/upgrade-2nd-gen

Support for First Generation instances ended January 30, 2020 and you no longer can create First Generation instances.

See: https://cloud.google.com/sql/docs/mysql/upgrade-2nd-gen
@Temikus
Copy link
Member Author

Temikus commented Mar 26, 2020

@icco I'm not going to break compatibility, but I am planning to remove the CI, tests and any first-tier exclusive methods as they're going to be unusable.

You reckon this should be a minor or a major version release?

@icco
Copy link
Member

icco commented Mar 26, 2020

Minor I think is reasonable

@Temikus Temikus changed the title [WIP] Removing SQLv1 API [WIP] Removing SQLv1 API + small SQL model fixes Mar 26, 2020
Now it actually tracks the operation in progress, so we don't get Google::Apis::ClientError: operationInProgress if we try to touch the instance immediately after.
- Restructured tests and removed v1-specific ones
- Updated test factories
- Updated examples
@Temikus Temikus changed the title [WIP] Removing SQLv1 API + small SQL model fixes Removing SQLv1 API support + small SQL model fixes Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #493 into master will increase coverage by 1.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   87.94%   89.01%   +1.06%     
==========================================
  Files         340      340              
  Lines        5659     5661       +2     
==========================================
+ Hits         4977     5039      +62     
+ Misses        682      622      -60
Impacted Files Coverage Δ
lib/fog/google/models/sql/ssl_cert.rb 89.18% <100%> (+34.9%) ⬆️
lib/fog/google/models/sql/instance.rb 79.5% <0%> (+10.65%) ⬆️
lib/fog/google/requests/sql/list_users.rb 100% <0%> (+12.5%) ⬆️
lib/fog/google/requests/sql/delete_user.rb 100% <0%> (+12.5%) ⬆️
...g/google/requests/sql/reset_instance_ssl_config.rb 100% <0%> (+12.5%) ⬆️
lib/fog/google/requests/sql/insert_ssl_cert.rb 100% <0%> (+12.5%) ⬆️
lib/fog/google/requests/sql/delete_ssl_cert.rb 100% <0%> (+12.5%) ⬆️
lib/fog/google/requests/sql/get_ssl_cert.rb 100% <0%> (+12.5%) ⬆️
lib/fog/google/requests/sql/list_ssl_certs.rb 100% <0%> (+12.5%) ⬆️
lib/fog/google/requests/sql/insert_user.rb 100% <0%> (+12.5%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1bee...d689d77. Read the comment docs.

@Temikus Temikus requested a review from icco March 26, 2020 11:19
@Temikus Temikus merged commit e2ca89b into fog:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants