Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rhel sap cloud image project #490

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

kgaikwad
Copy link
Contributor

No description provided.

@Temikus
Copy link
Member

Temikus commented Mar 20, 2020

@kgaikwad Thanks for this!

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #490 into master will decrease coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage      89%   87.94%   -1.07%     
==========================================
  Files         340      340              
  Lines        5659     5659              
==========================================
- Hits         5037     4977      -60     
- Misses        622      682      +60
Impacted Files Coverage Δ
lib/fog/compute/google/models/images.rb 90% <ø> (ø) ⬆️
lib/fog/google/models/sql/user.rb 46.42% <0%> (-50%) ⬇️
lib/fog/google/requests/sql/update_instance.rb 63.63% <0%> (-36.37%) ⬇️
lib/fog/google/models/sql/ssl_certs.rb 45% <0%> (-35%) ⬇️
lib/fog/google/models/sql/ssl_cert.rb 54.28% <0%> (-34.29%) ⬇️
lib/fog/google/models/sql/users.rb 80% <0%> (-20%) ⬇️
lib/fog/google/requests/sql/list_users.rb 87.5% <0%> (-12.5%) ⬇️
lib/fog/google/requests/sql/delete_user.rb 87.5% <0%> (-12.5%) ⬇️
...g/google/requests/sql/reset_instance_ssl_config.rb 87.5% <0%> (-12.5%) ⬇️
lib/fog/google/requests/sql/insert_ssl_cert.rb 87.5% <0%> (-12.5%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82c2c5...ff0670b. Read the comment docs.

@Temikus
Copy link
Member

Temikus commented Mar 20, 2020

Everything passes except for SQLv1 API, which is now deprecated, merging.

@Temikus Temikus merged commit 46d1bee into fog:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants