Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t count non-implemented mocks in code coverage #465

Merged
merged 1 commit into from
May 30, 2019

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented May 30, 2019

Looking at our coverage graphs we're counting in non-implemented mocks in code coverage which doesn't make much sense.

This PR is an attempt to fix that so finding models that need better coverage is easier.

@@ -5,6 +5,7 @@

require 'codecov'
SimpleCov.formatter = SimpleCov::Formatter::Codecov
SimpleCov.skip_token('no-coverage')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #465 into master will increase coverage by 3.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   85.65%   88.86%   +3.21%     
==========================================
  Files         339      339              
  Lines        5840     5629     -211     
==========================================
  Hits         5002     5002              
+ Misses        838      627     -211
Impacted Files Coverage Δ
lib/fog/compute/google/requests/insert_server.rb 82.22% <ø> (+1.78%) ⬆️
lib/fog/compute/google/requests/get_target_pool.rb 100% <ø> (+10%) ⬆️
lib/fog/storage/google_json/requests/put_object.rb 100% <ø> (+4.54%) ⬆️
...oogle/requests/list_aggregated_forwarding_rules.rb 100% <ø> (+11.11%) ⬆️
...mpute/google/requests/insert_target_https_proxy.rb 100% <ø> (+11.11%) ⬆️
...ib/fog/compute/google/requests/get_machine_type.rb 100% <ø> (+10%) ⬆️
lib/fog/google/requests/sql/import_instance.rb 50% <ø> (+3.33%) ⬆️
...pute/google/requests/get_instance_group_manager.rb 100% <ø> (+11.11%) ⬆️
...oogle/requests/remove_target_pool_health_checks.rb 70% <ø> (+6.36%) ⬆️
...ute/google/requests/list_aggregated_subnetworks.rb 100% <ø> (+11.11%) ⬆️
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e785f6d...b0cd0d6. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #465 into master will increase coverage by 5.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   85.65%   91.11%   +5.46%     
==========================================
  Files         339       24     -315     
  Lines        5840      720    -5120     
==========================================
- Hits         5002      656    -4346     
+ Misses        838       64     -774
Impacted Files Coverage Δ
...og/google/requests/monitoring/create_timeseries.rb 100% <ø> (+10%) ⬆️
...oogle/requests/monitoring/get_metric_descriptor.rb 100% <ø> (+11.11%) ⬆️
...le/requests/monitoring/create_metric_descriptor.rb 100% <ø> (+9.09%) ⬆️
...le/requests/monitoring/delete_metric_descriptor.rb 87.5% <ø> (+9.72%) ⬆️
.../monitoring/list_monitored_resource_descriptors.rb 100% <ø> (+11.11%) ⬆️
.../fog/google/requests/monitoring/list_timeseries.rb 61.9% <ø> (+2.81%) ⬆️
lib/fog/google/shared.rb 55.05% <0%> (-2.25%) ⬇️
lib/fog/compute/google/models/zones.rb
lib/fog/compute/google/models/projects.rb
lib/fog/google/models/sql/operations.rb
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e785f6d...b0cd0d6. Read the comment docs.

@Temikus Temikus merged commit 551ebb5 into fog:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants