Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “host” parameter to SQL user factory #463

Merged
merged 1 commit into from
May 29, 2019

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented May 29, 2019

Semi-temporary fix for #462

Tests are still very much valid but depending on the outcome of the internal issue we may need to make some adjustments.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         339      339           
  Lines        5840     5840           
=======================================
  Hits         5002     5002           
  Misses        838      838
Impacted Files Coverage Δ
lib/fog/google/models/sql/user.rb 96.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aa375...d72d6d4. Read the comment docs.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #463 into master will increase coverage by 4.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #463     +/-   ##
=========================================
+ Coverage   85.65%   90.35%   +4.7%     
=========================================
  Files         339       24    -315     
  Lines        5840      726   -5114     
=========================================
- Hits         5002      656   -4346     
+ Misses        838       70    -768
Impacted Files Coverage Δ
lib/fog/google/shared.rb 55.05% <0%> (-2.25%) ⬇️
lib/fog/compute/google/models/zones.rb
lib/fog/compute/google/models/projects.rb
lib/fog/compute/google/requests/list_images.rb
lib/fog/storage/google_json/requests/put_object.rb
...oogle/requests/list_aggregated_forwarding_rules.rb
...mpute/google/requests/insert_target_https_proxy.rb
...ib/fog/compute/google/requests/get_machine_type.rb
.../fog/compute/google/requests/get_zone_operation.rb
lib/fog/google/models/sql/operations.rb
... and 305 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aa375...d72d6d4. Read the comment docs.

@Temikus Temikus merged commit 29b40f2 into fog:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants