Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compute disk auto delete hash key #307

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Fix compute disk auto delete hash key #307

merged 1 commit into from
Mar 5, 2018

Conversation

seanmalloy
Copy link
Contributor

The correct name is :auto_delete and not :autoDelete.

@seanmalloy
Fix compute disk auto delete hash key
d8ffa64 
The correct name is :auto_delete and not :autoDelete.
@seanmalloy seanmalloy mentioned this pull request Mar 4, 2018
Merged
@seanmalloy
Copy link
Contributor Author

For reference here is the code in the google-api-ruby-client that ultimately uses the :auto_delete hash key.

https://github.com/google/google-api-ruby-client/blob/master/generated/google/apis/compute_v1/classes.rb#L1079

@icco
Copy link
Member

icco commented Mar 5, 2018

Thanks!

@icco icco merged commit c42060f into fog:master Mar 5, 2018
@seanmalloy seanmalloy mentioned this pull request Mar 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icco icco icco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmalloy @icco