Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert_server.rb scheduling option #304

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Fix insert_server.rb scheduling option #304

merged 1 commit into from
Feb 14, 2018

Conversation

seanmalloy
Copy link
Contributor

No description provided.

@seanmalloy
Copy link
Contributor Author

It looks lijke ::Google::Apis::ComputeV1::ServiceAccount is being called instead of Google::Apis::ComputeV1::Scheduling when the :scheduling option is being used.

I have not tested this yet, but it looks like it should be a simple change. I'll try to test this tomorrow.

@seanmalloy
Copy link
Contributor Author

seanmalloy commented Feb 14, 2018

I was able to test this code and it is working. Let me know if any changes are needed on this PR.

@seanmalloy seanmalloy changed the title WIP: fix insert_server.rb scheduling option Fix insert_server.rb scheduling option Feb 14, 2018
The conditional statement for the scheduling option
was calling the wrong class, Google::Apis::ComputeV1::ServiceAccount. Class
Google::Apis::ComputeV1::Scheduling should be called instead. This pull
request fixes this issue.
@icco
Copy link
Member

icco commented Feb 14, 2018

Makes sense, thanks!

@icco icco merged commit 3f1130e into fog:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants