Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to nonexistent function #301

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Remove call to nonexistent function #301

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c471aa4
Remove call to nonexistent function
icco Feb 5, 2018
bc02ff9
Fix style concerns
icco Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/fog/compute/google/models/disk.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,14 @@ def attached_disk_obj(opts = {})
end

def get_as_boot_disk(writable = true, auto_delete = false)
get_object(writable, true, nil, auto_delete)
mode = writable ? "READ_WRITE" : "READ_ONLY"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assign variables inside of conditionals

{
autoDelete: auto_delete,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hash rockets syntax.

boot: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hash rockets syntax.

source: self_link,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hash rockets syntax.

mode: mode,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hash rockets syntax.

type: "PERSISTENT"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hash rockets syntax.

}
end

def ready?
Expand Down