Migrate monitoring code to V3 API #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icco
approved these changes
Sep 26, 2017
|
@icco done! I think I'll hold off on tests for this one and add them in my new branch PR |
icco
reviewed
Sep 26, 2017
README.md
Outdated
| @@ -34,7 +34,7 @@ Fog implements [v1](https://cloud.google.com/dns/api/v1/) of the Google Cloud DN | |||
|
|
|||
| ## Monitoring | |||
|
|
|||
| Fog implements [v2beta2](https://cloud.google.com/monitoring/v2beta2/) of the Google Cloud Monitoring API. As of 2016-03-15, we believe Fog for Google Cloud Monitoring is feature complete. We are always looking for people to improve our code and test coverage, so please [file issues](https://github.com/fog/fog-google/issues) for any anomalies you see or features you would like. | |||
| Fog implements [v3](https://cloud.google.com/monitoring/api/ref_v3/rest/) of the Google Cloud Monitoring API. We are always looking for people to improve our code and test coverage, so please [file issues](https://github.com/fog/fog-google/issues) for any anomalies you see or features you would like. | |||
There was a problem hiding this comment.
Could you put in today's date with some statement on API coverage?
|
Thanks! |
jakob-ml
pushed a commit
to MeisterLabs/fog-google
that referenced
this pull request
Jan 10, 2018
Migrate monitoring code to V3 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking about this with @selmanj, we decided to just migrate the models as well and we'll work with partners to migrate them over. One of the resources just doesn't really exist anymore, so we can't really keep it backwards compatible.
Please let me know if everything looks ok! I ended up removing the shindo tests but let me know if you want me to add other tests to compensate - kinda feels dirty without tests.