Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .fog.example and amending docs #207

Merged
merged 2 commits into from
May 7, 2017
Merged

Adding .fog.example and amending docs #207

merged 2 commits into from
May 7, 2017

Conversation

palladius
Copy link
Contributor

[trying my first pull request here! So apologies for newbbisities]

Adding a sample file for .fog and proposing in the docs to just append this sample into your home fog (I'm not an expert but I presume this is safer than a CP as people might have stuff already in there). Ideally if you like this idea I can actually remove the same stuff from README (more DRY) - but I wasnt sure.

Copy link
Member

@Temikus Temikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

See my comments inline.

README.md Outdated
@@ -76,6 +76,8 @@ my_credential:
google_json_key_location: /path/to/my-project-xxxxxxxxxxxx.json
```

Or simply `cat .fog.example >> ~.fog` and edit parameters in the file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~.fog is an incorrect glob, as it'll resolve to: /Users/myuser.fog, you need a slash: ~/.fog

.fog.example Outdated
@@ -0,0 +1,12 @@
#####################################################
# This is configuration snippet to configure Google Cloud Platform
# for fig library.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

.fog.example Outdated
# 2. Follow instructions to generate a private key:
# https://cloud.google.com/storage/docs/authentication#generating-a-private-key

my_credential:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I do admit that's our doc issue, I'm not sure if my_credential will actually work by default if you didn't explicitly load them via Fog::Credentials. AFAIK only "default" works by default and whatever is in "test" is loaded by tests.

Have you tested this?

@palladius
Copy link
Contributor Author

ACK on comments - thanks.

  1. Now I don't know how to amend this pull request to address the required changes. Let me study this out :) Using https://gist.github.com/Chaser324/ce0505fbed06b947d962 as study point.

  2. Ok - addressed both bugs in new public branch: https://github.com/palladius/fog-google/tree/newfeature

@palladius
Copy link
Contributor Author

New commit which addresses Temikus comments: palladius@93781eb

@Temikus
Copy link
Member

Temikus commented Apr 25, 2017

@palladius LGTM, thanks for contributing \o/ Sorry it took a while.

One last note - I suggest setting your git config to a proper email, so you get the contribution tracked on github properly. Currently your commit's email is set to "[email protected]". Either associate that with GitHub or:

git rebase -i HEAD~2
git commit --amend --author="Riccardo Carlesso [email protected]"

Cheers!

@icco
Copy link
Member

icco commented Apr 25, 2017

(You'll need to git push -f after rebasing for this to update.) 👋 @palladius!

@palladius
Copy link
Contributor Author

Thanks bros! Done the following:

git rebase -i HEAD~2
git commit --amend --author="Riccardo Carlesso [email protected]"
git push -f

@icco icco merged commit 98db230 into fog:master May 7, 2017
@icco
Copy link
Member

icco commented May 7, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants