Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute client throws when listing snapshots #239

Closed
selmanj opened this issue Aug 1, 2017 · 0 comments
Closed

Compute client throws when listing snapshots #239

selmanj opened this issue Aug 1, 2017 · 0 comments

Comments

@selmanj
Copy link
Contributor

selmanj commented Aug 1, 2017

When no snapshots exist and snapshots.all is called on a compute client, an error is thrown:

TypeError: no implicit conversion of nil into Array
    /Users/jsselman/src/fog-google/lib/fog/compute/google/models/snapshots.rb:12:in `concat'
    /Users/jsselman/src/fog-google/lib/fog/compute/google/models/snapshots.rb:12:in `block in all'
    /Users/jsselman/src/fog-google/lib/fog/compute/google/models/snapshots.rb:10:in `loop'
    /Users/jsselman/src/fog-google/lib/fog/compute/google/models/snapshots.rb:10:in `all'

Regression introduced in #222 , reported by @agrare
selmanj added a commit to selmanj/fog-google that referenced this issue Aug 1, 2017
@selmanj
Check for empty snapshots when listing
d883b26 
Fixes fog#239
@selmanj selmanj mentioned this issue Aug 1, 2017
Merged
agrare added a commit to agrare/manageiq-providers-google that referenced this issue Aug 1, 2017
@agrare
Workaround a bug in fog-google around snapshots
a0144af 
There is a bug in fog-google which causes an exception to be raised when
there are no snapshots present on the provider causing the refresh
to fail.

Issue raised in fog-google here
fog/fog-google#239

This can be removed once fog/fog-google#240 is
merged and released.
@agrare agrare mentioned this issue Aug 1, 2017
Closed
@icco icco closed this as completed in #240 Aug 2, 2017
jakob-ml pushed a commit to MeisterLabs/fog-google that referenced this issue Jan 10, 2018
@selmanj
Check for empty snapshots when listing
26200bd 
Fixes fog#239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@selmanj