Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DNS::AWS to AWS::DNS #469

Merged
merged 14 commits into from
Sep 17, 2018
Merged

Rename DNS::AWS to AWS::DNS #469

merged 14 commits into from
Sep 17, 2018

Conversation

sue445
Copy link
Contributor

@sue445 sue445 commented Sep 17, 2018

Fixes fog-core deprecation warning

[fog][DEPRECATION] Unable to load Fog::AWS::DNS
[fog][DEPRECATION] The format Fog::DNS::AWS is deprecated

Part of #466

sue445 added 12 commits September 17, 2018 23:03
@sue445
Add AWS::DNS
3256c95
@sue445
git grep -l "module DNS" -- lib/fog/aws/models/dns/ | xargs sed -i ""…
23213cc 
… "s/module DNS/module AWS/g"
@sue445
git grep -l "class AWS" -- lib/fog/aws/models/dns/ | xargs sed -i "" …
5dd4bcc 
…"s/class AWS/class DNS/g"
@sue445
git grep -l " module DNS" -- lib/fog/aws/parsers/dns/ | xargs sed -i …
538d6a6 
…"" "s/ module DNS/ module AWS/g"
@sue445
git grep -l " module AWS" -- lib/fog/aws/parsers/dns/ | xargs sed -i …
0b8bd96 
…"" "s/ module AWS/ module DNS/g"
@sue445
git grep -l "DNS::AWS" -- lib/ | xargs sed -i "" "s/DNS::AWS/AWS::DNS/g"
f9cc6bf
@sue445
git grep -l "DNS::AWS" -- tests/ | xargs sed -i "" "s/DNS::AWS/AWS::D…
aa26a2c 
…NS/g"
@sue445
git grep -l "module DNS" -- lib/fog/aws/dns.rb | xargs sed -i "" "s/m…
9e88a9c 
…odule DNS/module AWS/g"
@sue445
git grep -l "class AWS" -- lib/fog/aws/dns.rb | xargs sed -i "" "s/cl…
626b0f0 
…ass AWS/class DNS/g"
@sue445
git grep -l "module DNS" -- lib/fog/aws/requests/dns/ | xargs sed -i …
805f590 
…"" "s/module DNS/module AWS/g"
@sue445
git grep -l "class AWS" -- lib/fog/aws/requests/dns/ | xargs sed -i "…
f0f6126 
…" "s/class AWS/class DNS/g"
@sue445
Deprecate DNS::AWS
5a9f1af
@sue445 sue445 mentioned this pull request Sep 17, 2018
Closed
@geemus
Copy link
Member

geemus commented Sep 17, 2018

@sue445 looks good, just noticed that it looks like merging your first changeset must have introduced a conflict with this one. Could you help resolve that so that I can bring this in?

@geemus
Copy link
Member

geemus commented Sep 17, 2018

@sue445 never mind, pretty sure I got it. As long as tests pass again, I think we should be good to go. Thanks!

@geemus geemus merged commit 3025957 into fog:master Sep 17, 2018
@geemus
Copy link
Member

geemus commented Sep 17, 2018

Thanks!

@sue445 sue445 deleted the fix_dns_deprecation_warning branch September 17, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geemus geemus geemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sue445 @geemus