Rename CDN::AWS to AWS::CDN

[jaredbeck]

Fixes fog-core deprecation warning

[fog][DEPRECATION] Unable to load Fog::AWS::CDN
[fog][DEPRECATION] The format Fog::CDN::AWS is deprecated

Part of #466

[plribeiro3000]

👍 from me.

Need someone active on this repo to look and merge tho

[jaredbeck]

How should I run tests locally? I couldn't find any docs on it. So, I just pushed and hoped for CI to pass.

[jaredbeck]

Also,

Add a new class that just aliases (and will raise the warning if anybody includes directly).

I don't know how to do a warning. ActiveSupport has deprecate_constant but I assumed you don't want that dependency.

[plribeiro3000]

I believe you can just overwrite the constructor raising a deprecation notice and call super in the next line.

[jaredbeck]

I believe you can just overwrite the constructor raising a deprecation notice and call super in the next line.

Sorry, I don't understand. Which constructor?

Also, the assignment ..

# fog/aws/cdn.rb
Fog::CDN::AWS = Fog::AWS::CDN

.. is "by reference", so overwriting a method would affect both constants, wouldn't it?

[plribeiro3000]

Yeap, the construction you made is not gonna work.

You will have to open the class and inherit manually then overwrite the method initialize.

If you take a look at the Fog::Service module you will see it has a new method being defined here

Sou you can open the class and define it like:

class Fog::CDN::AWS < Fog::AWS::CDN
  def self.new(config = {})
    Fog::Logger.deprecation 'Your message here'
    super(config)
  end
end

[jaredbeck]

You will have to open the class and inherit manually then overwrite the method initialize.

Done. Thanks.

[geemus]

Looks good to me, @plribeiro3000 does that match with what you were asking?