Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: update the afrim dependency #70

Merged
merged 5 commits into from
Apr 24, 2024
Merged

patch: update the afrim dependency #70

merged 5 commits into from
Apr 24, 2024

Conversation

pythonbrad
Copy link
Member

@pythonbrad pythonbrad commented Apr 24, 2024

Related issue

Change

This update will permit to implement more features.
By example, pausing/resuming the afrim.

As major additional change:

  • we rename Wish::destroy by Wish::kill,
    since it closes the program (both wish and rust) internally
  • we change the default behavior of the close button of the titlebar
    on the main window

This update will permit to implement more features.
By example, pausing/resuming the afrim.

As major additional change:
- we rename `Wish::destroy` by `Wish::kill`,
 since it closes the program (both wish and rust) internally
- we change the default behavior of the close button of the titlebar
 on the main window
We forget to check if the afrim_wish end as expected.
@pythonbrad pythonbrad self-assigned this Apr 24, 2024
@coveralls
Copy link

coveralls commented Apr 24, 2024

Pull Request Test Coverage Report for Build 8819145357

Details

  • 157 of 165 (95.15%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.1%) to 90.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 131 139 94.24%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 2 91.4%
Totals Coverage Status
Change from base Build 8818518096: 2.1%
Covered Lines: 620
Relevant Lines: 688

💛 - Coveralls

@pythonbrad pythonbrad merged commit 77873d9 into main Apr 24, 2024
5 checks passed
@pythonbrad pythonbrad deleted the patch_deps branch April 24, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants