Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes escape character of an alias when setting target #697

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

pderaaij
Copy link
Collaborator

@pderaaij pderaaij commented Jul 3, 2021

This resolves #695 and additionally also provides better input for the graph rendering. When setting the target, the escape character is now explicitly removed.

@pderaaij pderaaij force-pushed the bug/aliases_in_tables branch from f5027a1 to 36da829 Compare July 3, 2021 19:19
@pderaaij
Copy link
Collaborator Author

pderaaij commented Jul 7, 2021

@riccardoferretti I can use your help here. I am stuck getting the tests stable. For whatever reason, the tests are flaky and randomly fail due to disposed editors. I don't understand what is happening here. It seems to be caused from another test, but I can't find a consistent relation. Would appreciate if you can have a look at this. Perhaps you find the right thing that's causing this.

@pderaaij pderaaij force-pushed the bug/aliases_in_tables branch from d61006b to fcb3708 Compare July 10, 2021 18:14
@pderaaij
Copy link
Collaborator Author

@riccardoferretti Looks like I found the issue. The problems seem to be caused by the after save wikilink reference definition generation. As it's not needed for these tests, I am disabling them via updating the configuration. On the hand, this could be the default behaviour for all tests.

@riccardoferretti
Copy link
Collaborator

You are a hero for finding this, I was not looking anywhere near that, I thought the issue was in the test setup/teardown. 🎉🎉🎉

Copy link
Collaborator

@riccardoferretti riccardoferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riccardoferretti riccardoferretti merged commit 97629a2 into foambubble:master Jul 12, 2021
@pderaaij pderaaij deleted the bug/aliases_in_tables branch October 28, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links with aliases in Tables
2 participants