Allow for dots in wikilinks #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardoferretti
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
I originally thought this was a good workaround to achieve support for dots in filenames, but looking at it I wonder if it's simply a good solution in its own right.
I feel there is a bigger topic of mapping wikilinks to resources that still needs some ironing, but in the meantime this elegantly does the job, great thinking!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for dendron-style wikilinks, resolves #672. Due to the correct behaviour, it ensures proper working of the graph and explorer functions as well.