WIP: Fix wikilinks slug querying #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanketDG
commented
Nov 27, 2020
| @@ -91,7 +91,7 @@ export class NoteGraph implements NoteGraphAPI { | |||
| // prettier-ignore | |||
| const filterFn = | |||
| query == null ? (note: Note | null) => note != null | |||
| : 'slug' in query ? (note: Note | null) => note?.slug === query.slug | |||
| : 'slug' in query ? (note: Note | null) => [nameToSlug(query.slug), query.slug].includes(note?.slug as string) | |||
There was a problem hiding this comment.
I am checking for both [[Slug Name]] and [[slug-name]] here, however they are defined in the note, so both can be used interchangably.
There was a problem hiding this comment.
@SanketDG I have a feeling this wouldn't work with the dataviz graph, have you tested it?
There was a problem hiding this comment.
Yes it definitely works with my notes, which all have filenames like "javascript-execution.md" and referenced as [[Javascript Execution]], this is uniform throughout.
Any other cases you want me to check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix the wikilink generation issues.