Fix embedded notes not generating proper reference links #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardoferretti
approved these changes
Sep 22, 2023
Comment on lines
149
to
150
| } else { | ||
| label = link.rawText; |
There was a problem hiding this comment.
I believe this can be removed
Suggested change
| } else { | |
| label = link.rawText; |
There was a problem hiding this comment.
nice! updated, lemme know if it's too "busy"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when generating reference links for a note that includes embedded notes, the reference links have a syntax error.
This is caused by an off-by-one error when extracting the label after gathering the links for a note since embedded notes have an extra
!.After the fix:
Appreciate any feedback!