The method setTrackerUrl is registered more than once in "_paq" variable #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
suggested changes
Mar 27, 2018
view/frontend/web/js/tracker.js
Outdated
| ['setTrackerUrl', defaultTrackerUrl] | ||
| ]); | ||
| injectScript(options.scriptUrl); | ||
| if (scriptExists(options.scriptUrl)) { |
There was a problem hiding this comment.
There should be opposite check.
igortregub
force-pushed
the
igortregub-patch-1
branch
from
7a6b85d to
ed91fa3
Compare
ihor-sviziev
approved these changes
Mar 27, 2018
|
@henkelund could you merge this PR? |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is described in #28