Fix handling of ImageConfig creation #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
EngHabu
previously approved these changes
Apr 28, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
kumare3
reviewed
Apr 28, 2022
| def create_from( | ||
| cls, default_image: Optional[Image], other_images: typing.Optional[typing.List[Image]] = None | ||
| ) -> ImageConfig: | ||
| if default_image and not isinstance(default_image, Image): |
There was a problem hiding this comment.
Why not a simple str too and then we do the conversion?
There was a problem hiding this comment.
will add in a separate PR.
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 86.26% 86.28% +0.01%
==========================================
Files 252 252
Lines 24129 24137 +8
Branches 2745 2747 +2
==========================================
+ Hits 20815 20826 +11
+ Misses 2846 2843 -3
Partials 468 468
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <[email protected]>
EngHabu
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yee Hing Tong [email protected]
TL;DR
create_fromis not anImageobject.from_imageswork.Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/