Enable queuing_budget in Workflow Metadata #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migueltol22
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
| return _core_workflow.WorkflowMetadata() | ||
| workflow_metadata = _core_workflow.WorkflowMetadata() | ||
| if self._queuing_budget: | ||
| workflow_metadata.queuing_budget.FromTimedelta(self.queuing_budget) |
There was a problem hiding this comment.
That is correct.
flytekit/__init__.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| from __future__ import absolute_import | |||
| import flytekit.plugins | |||
|
|
|||
| __version__ = '0.7.0b1' | |||
| __version__ = '0.7.0b2' | |||
wild-endeavor
approved these changes
Apr 8, 2020
wild-endeavor
approved these changes
Apr 8, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
* support queuing budget in workflow metadata * add queuing budget to wf * add typehint to docstring * add test_workflow_queueing_budget * b3 and add test with queuing budget not set * add test_workflow_with_queuing_budget * upd test name Co-authored-by: Yee Hing Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Allow a user to specify
queueing_budgetparameter for their workflow. This parameter corresponds to the amount of time a user is willing to wait for a workflow to be executed.FlyteIDL PR: flyteorg/flyteidl#50
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#245
Follow-up issue
NA